Skip to content

Move unic-ucd-utils to unic-utils-codepoints #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Move unic-ucd-utils to unic-utils-codepoints #49

merged 1 commit into from
Jul 25, 2017

Conversation

behnam
Copy link
Member

@behnam behnam commented Jul 24, 2017

Create unic-utils component and put the Code Point-related utilities
under a new component named unic-utils-codepoints.

@CAD97
Copy link
Collaborator

CAD97 commented Jul 24, 2017

Did you mean

Create unic-utils component and put the Code Point-related utilities
under a new component named unic-utils-codepoints

?

Once you merge this I'll patch #48 to crate unic-utils-char-property (or unic-utils-char_property)

@behnam
Copy link
Member Author

behnam commented Jul 24, 2017

Thanks, @CAD97. Fixed.

Yeah, I though doing this first would make it easier for other utils crates.

I'm also going to submit a draft for char-property trait, which shows what's possible at the moment, and we can see if we want to write a separate macro, or via the char_property macro you've been working on, for the actual implementation.

Copy link
Collaborator

@CAD97 CAD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is valid anymore: https://github.com/behnam/rust-unic/pull/49/files#diff-cef149cbfaec93687e5722f06b321305R19

/// Range of Surrogate Code Points, which are not Unicde Scalar Values.
const SCALAR_VALUE_RANGE_1: Range<u32> = 0x0..0xD800;
const SCALAR_VALUE_RANGE_2: Range<u32> = (0xDFFF + 1)..(0x10_FFFF + 1);

It seems this changed from subtracting the surrogates from the full range to chaining together the two non-surrogate ranges, and the comment didn't get updated.

Now seems like a good time to fix it. Otherwise, let's go to master!

@behnam
Copy link
Member Author

behnam commented Jul 24, 2017

Good catch! Updated the doc-blocks.

Create `unic-utils` component and put the Code Point-related utilities
under a new component named `unic-utils-codepoints`.
@behnam behnam merged commit 438f705 into master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants