v4.1.x: common/ofi: added address format check to fix provider selection #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancejic
changed the title
|
Please see step 8 of https://github.com/open-mpi/ompi/wiki/SubmittingPullRequests. You need to include the cherry-pick from line generated by "cherry-pick -x". |
bugfix: provider selection would not differentiate between ipv4 and ipv6 addresses which would cause some nodes to be unable to communicate between each other. Adding a check for address format to provider selection to ensure that all nodes use the same address format. Signed-off-by: Nikola Dancejic <[email protected]> (cherry picked from commit 7e46371)
|
@bwbarrett Can you review this PR? |
bwbarrett
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: provider selection would not differentiate between ipv4
and ipv6 addresses which would cause some nodes to be unable
to communicate between each other. Adding a check for address
format to provider selection to ensure that all nodes use the
same address format.
Signed-off-by: Nikola Dancejic [email protected]
(cherry picked from commit 7e46371)