add support for aws sso credentials provider #7527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Efi Shtain <[email protected]>
efiShtain
force-pushed
the
support-aws-sso-credentials
branch
from
5e02b0c to
061404c
Compare
There was a problem hiding this comment.
Hey @efiShtain, thanks for this PR. It looks great to me.
Just so that I have this straight, this is to allow human users to pull bundles from s3 which are typically loaded by OPAs authenticated via some other means (e.g. instance identity document etc.). This would mainly be used for local developer testing?
Would it be possible to add some documentation around this new feature pointing to the relevant documentation e.g. https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sso.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
The PR adds the ability to work with aws sso credentials to load bundles from s3
It allows working locally with sso tokens, fetching credentials tokens when needed
I needed it to be able to work the same without changing the configuration on local (with sso credentials) and cloud (ec2/ecs)