[dockerobserver] incorporate EndpointsWatcher and fix startup bug #11541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
commented
Jun 24, 2022
rmfitzpatrick
force-pushed
the
dockerendpointswatcher
branch
4 times, most recently
from
46c48f0 to
200ea63
Compare
rmfitzpatrick
force-pushed
the
dockerendpointswatcher
branch
2 times, most recently
from
b7a1ea5 to
863e023
Compare
dmitryax
reviewed
Jul 12, 2022
rmfitzpatrick
force-pushed
the
dockerendpointswatcher
branch
from
863e023 to
cb0c197
Compare
rmfitzpatrick
commented
Jul 13, 2022
dmitryax
reviewed
Jul 13, 2022
rmfitzpatrick
force-pushed
the
dockerendpointswatcher
branch
from
cb0c197 to
8445595
Compare
rmfitzpatrick
force-pushed
the
dockerendpointswatcher
branch
from
8445595 to
22a3e72
Compare
dmitryax
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - These changes move the docker observer to include the existing observer.EndpointsWatcher functionality in preparation for supporting multiple subscribers. They also fix a bug that prevented existing containers from being reported as endpoints at startup.
edit: I've updated this PR to remove its redundant logic from what's available in the internal docker client helper.
Link to tracking Issue: #10830
Testing: updated existing tests for functional changes
Documentation: changelog update