[exporter/sentryexporter] Omit empty parent span id #13415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentry.TraceContext must be a pointer in order for it to be properly marshalled. See: https://github.com/getsentry/sentry-go/blob/v0.13.0/tracing.go#L484
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
AbhiPrasad
approved these changes
Sep 7, 2022
|
@djaglowski @codeboten I think this is good to merge in! |
codeboten
approved these changes
Sep 9, 2022
codeboten
reviewed
Sep 12, 2022
There was a problem hiding this comment.
Please add a changelog for this change: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When events without a parent span id is sent to Sentry, the trace context parent span id will have a value of
0000000000000000when the parent span id field should be omitted if empty. This is because whensentry.TraceContextis added to the event context it is not a pointer, thus the customMarshalJSON()func ofsentry.TraceContext(with pointer receiver) is not used.This PR changes the
sentry.TraceContextform value to pointer when added to the event context.Link to tracking Issue:
Testing:
Added tests to confirm that the event is marshalled properly with and without a parent span id.
Documentation: