-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Permanently enable 'telemetry.newPipelineTelemetry' feature gate #12856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanently enable 'telemetry.newPipelineTelemetry' feature gate #12856
Conversation
5f9ec2d
to
c9cbf6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12856 +/- ##
==========================================
+ Coverage 91.47% 91.52% +0.04%
==========================================
Files 494 494
Lines 26993 26982 -11
==========================================
+ Hits 24691 24694 +3
+ Misses 1818 1809 -9
+ Partials 484 479 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c9cbf6a
to
474815c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two suggestions
ec8eaf9
to
d8ac16f
Compare
It's been pointed out elsewhere that since the feature gate being enabled is a workaround for the problems it introduced, it's likely that users will already be using the gate. Therefore, removing it outright would break users. Our featuregate docs explicitly call out that We can also just move the gate along our normal path to |
c332465
to
3e6aeda
Compare
3e6aeda
to
66328e7
Compare
The spell check failure appears to be bogus and unrelated to this PR. |
Co-authored-by: Jade Guiton <[email protected]>
…ate (open-telemetry#12856)" This reverts commit dc8e2dd.
Discussed offline in relation to #12812
Introduction of this gate had some unintended side effects, such as removing attributes from loggers.