Skip to content

Permanently enable 'telemetry.newPipelineTelemetry' feature gate #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025

Conversation

djaglowski
Copy link
Member

Discussed offline in relation to #12812

Introduction of this gate had some unintended side effects, such as removing attributes from loggers.

@github-actions github-actions bot requested review from dmathieu and mx-psi April 15, 2025 14:03
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (78663f9) to head (208b49b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12856      +/-   ##
==========================================
+ Coverage   91.47%   91.52%   +0.04%     
==========================================
  Files         494      494              
  Lines       26993    26982      -11     
==========================================
+ Hits        24691    24694       +3     
+ Misses       1818     1809       -9     
+ Partials      484      479       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two suggestions

@djaglowski
Copy link
Member Author

It's been pointed out elsewhere that since the feature gate being enabled is a workaround for the problems it introduced, it's likely that users will already be using the gate. Therefore, removing it outright would break users.

Our featuregate docs explicitly call out that alpha gates may be immediately deprecated, but also that this is equivalent to permanently disabling the gate. Therefore, from a functionality perspective, stable is the most direct way to lock the gate into a permanently enabled state.

We can also just move the gate along our normal path to beta, but it's unclear that anyone would benefit from disabling the gate, and also IMO sends the wrong message that the gate is progressing as normal.

@djaglowski djaglowski closed this Apr 16, 2025
@djaglowski djaglowski reopened this Apr 16, 2025
@djaglowski djaglowski changed the title Remove 'telemetry.newPipelineTelemetry' feature gate Permanently enable 'telemetry.newPipelineTelemetry' feature gate Apr 16, 2025
@djaglowski
Copy link
Member Author

The spell check failure appears to be bogus and unrelated to this PR.

@bogdandrutu bogdandrutu added this pull request to the merge queue Apr 17, 2025
Merged via the queue into open-telemetry:main with commit dc8e2dd Apr 17, 2025
56 checks passed
@djaglowski djaglowski deleted the rm-attributes-gate branch April 17, 2025 17:36
songy23 added a commit to songy23/opentelemetry-service that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants