add NewAttributeMapFromMap, mark InitFromMap deprecated #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Aug 30, 2021
| @@ -38,41 +38,41 @@ const ( | |||
| ) | |||
|
|
|||
| func initResourceAttributes1(dest pdata.AttributeMap) { | |||
| dest.InitFromMap(resourceAttributes1) | |||
| pdata.NewAttributeMapFromMap(resourceAttributes1).CopyTo(dest) | |||
There was a problem hiding this comment.
Probably we can make the resourceAttributes1 to be AttributesMap, separate PR I am ok, but just an issue?
| } | ||
|
|
||
| func initMetricAttachment(dest pdata.AttributeMap) { | ||
| dest.InitFromMap(map[string]pdata.AttributeValue{TestAttachmentKey: pdata.NewAttributeValueString(TestAttachmentValue)}) | ||
| pdata.NewAttributeMapFromMap(map[string]pdata.AttributeValue{TestAttachmentKey: pdata.NewAttributeValueString(TestAttachmentValue)}).CopyTo(dest) |
| } | ||
|
|
||
| func initMetricAttributes1(dest pdata.AttributeMap) { | ||
| dest.InitFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1)}) | ||
| pdata.NewAttributeMapFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1)}).CopyTo(dest) |
| } | ||
|
|
||
| func initMetricAttributes12(dest pdata.AttributeMap) { | ||
| dest.InitFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1), TestLabelKey2: pdata.NewAttributeValueString(TestLabelValue2)}).Sort() | ||
| pdata.NewAttributeMapFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1), TestLabelKey2: pdata.NewAttributeValueString(TestLabelValue2)}).Sort().CopyTo(dest) |
| } | ||
|
|
||
| func initMetricAttributes13(dest pdata.AttributeMap) { | ||
| dest.InitFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1), TestLabelKey3: pdata.NewAttributeValueString(TestLabelValue3)}).Sort() | ||
| pdata.NewAttributeMapFromMap(map[string]pdata.AttributeValue{TestLabelKey1: pdata.NewAttributeValueString(TestLabelValue1), TestLabelKey3: pdata.NewAttributeValueString(TestLabelValue3)}).Sort().CopyTo(dest) |
| } | ||
|
|
||
| func initMetricAttributes2(dest pdata.AttributeMap) { | ||
| dest.InitFromMap(map[string]pdata.AttributeValue{TestLabelKey2: pdata.NewAttributeValueString(TestLabelValue2)}) | ||
| pdata.NewAttributeMapFromMap(map[string]pdata.AttributeValue{TestLabelKey2: pdata.NewAttributeValueString(TestLabelValue2)}).CopyTo(dest) |
bogdandrutu
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As per issue #3926, adding
NewAttributeMapFromMapfor consistency. As part of this also deprecating the existingInitFromMapwill will be removed once the contrib repo is updated.Link to tracking Issue: part of #3926
Testing: Updated existing tests