Rename configparser.Parser as config.Map
#4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
renameconfigmap
branch
from
4f9c2b7 to
577aead
Compare
mx-psi
approved these changes
Sep 20, 2021
dashpole
approved these changes
Sep 20, 2021
codeboten
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
configmap.ConfigMap stutters, but I don't have a better alternative to offer.
I agree with this, the only way I could imagine this not sounding repetitive is by moving out of the config package altogether. Moving it to config makes it slightly better to use config.ConfigMap but I don't know if it's worth the effort.
bogdandrutu
force-pushed
the
renameconfigmap
branch
3 times, most recently
from
6ab7780 to
4a66a6d
Compare
|
@codeboten @dashpole tried to make this |
bogdandrutu
changed the title
configparser.Parser as config.Map
dashpole
approved these changes
Sep 22, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
renameconfigmap
branch
2 times, most recently
from
4559625 to
2a60df9
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
renameconfigmap
branch
from
2a60df9 to
910c2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]