Deprecate configunmarshaler package, move it to internal #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
3 times, most recently
from
7a33b81 to
78c0634
Compare
Codecov Report
@@ Coverage Diff @@
## main #5151 +/- ##
==========================================
- Coverage 90.51% 90.48% -0.03%
==========================================
Files 186 187 +1
Lines 11033 11041 +8
==========================================
+ Hits 9987 9991 +4
- Misses 824 827 +3
- Partials 222 223 +1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
3 times, most recently
from
e4017f1 to
46e34c8
Compare
codeboten
reviewed
Apr 5, 2022
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
from
46e34c8 to
afb89cc
Compare
codeboten
approved these changes
Apr 6, 2022
This comment was marked as outdated.
This comment was marked as outdated.
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
from
afb89cc to
84f1ea4
Compare
|
@codeboten PTAL. |
codeboten
reviewed
Apr 12, 2022
codeboten
approved these changes
Apr 12, 2022
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
from
64f78eb to
c464bb1
Compare
Folllowup: * When the deprecated funcs/types are removed the internal package can be moved to service/internal. * Part of open-telemetry#4936 do not offer ability to configure ConfigUnmarshaler. Motivation: * This package is removed because with the latest addition of the `service.ConfigProvider` the usecase to change the unmarshaled config.Config can be achieved by wrapping/implementing that interface, so no clear use-case for this. In the future we can expose it again if we have good reasons. * During the review of another PR, this was mentioned as something some approvers/maintainers were concerned about what to do with this package. See open-telemetry#4608 (review) Updates open-telemetry#4605 Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
depcfgunmarshaler
branch
from
c464bb1 to
67d98c0
Compare
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…try#5151) Folllowup: * When the deprecated funcs/types are removed the internal package can be moved to service/internal. * Part of open-telemetry#4936 do not offer ability to configure ConfigUnmarshaler. Motivation: * This package is removed because with the latest addition of the `service.ConfigProvider` the usecase to change the unmarshaled config.Config can be achieved by wrapping/implementing that interface, so no clear use-case for this. In the future we can expose it again if we have good reasons. * During the review of another PR, this was mentioned as something some approvers/maintainers were concerned about what to do with this package. See open-telemetry#4608 (review) Updates open-telemetry#4605 Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folllowup:
Motivation:
service.ConfigProviderthe usecase to change the unmarshaled config.Config can be achieved by wrapping/implementing that interface, so no clear use-case for this. In the future we can expose it again if we have good reasons.config.Configandconfig.Service, useservice.Config*#4608 (review)Updates #4605
Signed-off-by: Bogdan Drutu [email protected]