Skip to content

Change featureflags package to make it test friendly #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Apr 6, 2022

Fixes: #4917

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #5160 (1740f87) into main (0674425) will increase coverage by 0.03%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #5160      +/-   ##
==========================================
+ Coverage   90.56%   90.60%   +0.03%     
==========================================
  Files         188      188              
  Lines       11091    11092       +1     
==========================================
+ Hits        10045    10050       +5     
+ Misses        825      822       -3     
+ Partials      221      220       -1     
Impacted Files Coverage Δ
service/zpages.go 70.33% <0.00%> (ø)
service/collector.go 77.43% <80.00%> (+0.42%) ⬆️
service/command.go 80.00% <100.00%> (ø)
service/featuregate/gates.go 100.00% <100.00%> (ø)
service/telemetry.go 76.25% <100.00%> (ø)
pdata/internal/common.go 94.94% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0674425...1740f87. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the change-featureflags-as-Prototype-to-make-test-friendly branch from a157f8f to 1097a71 Compare April 6, 2022 19:40
@bogdandrutu bogdandrutu marked this pull request as ready for review April 6, 2022 19:55
@bogdandrutu bogdandrutu requested review from a team and codeboten April 6, 2022 19:55
@bogdandrutu bogdandrutu force-pushed the change-featureflags-as-Prototype-to-make-test-friendly branch from 1097a71 to 25a4f25 Compare April 6, 2022 20:07
@bogdandrutu bogdandrutu changed the title Change featureflags as prototype to make test friendly Change featureflags to make test friendly Apr 6, 2022
@bogdandrutu bogdandrutu changed the title Change featureflags to make test friendly Change featureflags package to make it test friendly Apr 6, 2022
@bogdandrutu bogdandrutu force-pushed the change-featureflags-as-Prototype-to-make-test-friendly branch from 25a4f25 to d6b1dc5 Compare April 6, 2022 20:31
@bogdandrutu bogdandrutu force-pushed the change-featureflags-as-Prototype-to-make-test-friendly branch from d6b1dc5 to ae6ba78 Compare April 14, 2022 18:04
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM , just one nit

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach makes sense to me 👍

@dmitryax: the changelog has been fixed, PTAL

@codeboten codeboten merged commit addf0ef into open-telemetry:main Apr 25, 2022
@bogdandrutu bogdandrutu deleted the change-featureflags-as-Prototype-to-make-test-friendly branch April 25, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype test friendly featureflags
4 participants