-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Change featureflags package to make it test friendly #5160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change featureflags package to make it test friendly #5160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5160 +/- ##
==========================================
+ Coverage 90.56% 90.60% +0.03%
==========================================
Files 188 188
Lines 11091 11092 +1
==========================================
+ Hits 10045 10050 +5
+ Misses 825 822 -3
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
a157f8f
to
1097a71
Compare
1097a71
to
25a4f25
Compare
25a4f25
to
d6b1dc5
Compare
Signed-off-by: Kay Yan <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
d6b1dc5
to
ae6ba78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach LGTM , just one nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach makes sense to me 👍
@dmitryax: the changelog has been fixed, PTAL
Fixes: #4917