[pdata] Replace Request.Set<Signals> with NewRequestFrom<Signals>
#5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-request-set
branch
2 times, most recently
from
ba44981 to
834fb87
Compare
Codecov Report
@@ Coverage Diff @@
## main #5234 +/- ##
==========================================
- Coverage 90.65% 90.56% -0.10%
==========================================
Files 187 187
Lines 11052 11052
==========================================
- Hits 10019 10009 -10
- Misses 814 823 +9
- Partials 219 220 +1
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Apr 20, 2022
- `plogotlp.Request.SetLogs` func is deprecated in favor of `plogotlp.NewRequestFromLogs` - `pmetricotlp.Request.SetMetrics` func is deprecated in favor of `pmetricotlp.NewRequestFromMetrics` - `ptraceotlp.Request.SetTraces` func is deprecated in favor of `ptraceotlp.NewRequestFromTraces`
dmitryax
force-pushed
the
remove-request-set
branch
from
834fb87 to
6a7120f
Compare
bogdandrutu
approved these changes
Apr 20, 2022
jpkrohling
approved these changes
Apr 20, 2022
dashpole
approved these changes
Apr 20, 2022
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
bogdandrutu
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plogotlp.Request.SetLogsfunc is deprecated in favor ofplogotlp.NewRequestFromLogspmetricotlp.Request.SetMetricsfunc is deprecated in favor ofpmetricotlp.NewRequestFromMetricsptraceotlp.Request.SetTracesfunc is deprecated in favor ofptraceotlp.NewRequestFromTracesCloses #5230