Skip to content

Extend unmarshal hook to check map key string to any TextUnmarshaler not only ComponentID #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and mx-psi April 21, 2022 23:02
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #5244 (416c3fe) into main (dd4096b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 416c3fe differs from pull request most recent head d31484e. Consider uploading reports for the commit d31484e to get more accurate results

@@            Coverage Diff             @@
##             main    #5244      +/-   ##
==========================================
- Coverage   90.59%   90.56%   -0.03%     
==========================================
  Files         188      188              
  Lines       11082    11091       +9     
==========================================
+ Hits        10040    10045       +5     
- Misses        822      825       +3     
- Partials      220      221       +1     
Impacted Files Coverage Δ
config/configmap.go 90.09% <100.00%> (+0.51%) ⬆️
pdata/internal/common.go 94.16% <0.00%> (-0.78%) ⬇️
service/config_provider.go 90.08% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4096b...d31484e. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the cfgmapunmar branch 2 times, most recently from 55dea59 to 0646d25 Compare April 21, 2022 23:45
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a nit about the error message

@bogdandrutu bogdandrutu merged commit ea8937a into open-telemetry:main Apr 22, 2022
@bogdandrutu bogdandrutu deleted the cfgmapunmar branch April 22, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants