Remove deprecated service.Config #6774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Dec 13, 2022
| telemetry *telemetry.Telemetry | ||
| telemetrySettings component.TelemetrySettings | ||
| host *serviceHost | ||
| telemetryInitializer *telemetryInitializer | ||
| } | ||
|
|
||
| func New(set Settings) (*Service, error) { | ||
| func New(ctx context.Context, set Settings, cfg ConfigService) (*Service, error) { |
There was a problem hiding this comment.
Changes to New and Settings are not breaking since these 2 were made public this cycle.
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rmservicecfg
branch
from
0cd150b to
3af61c2
Compare
Codecov ReportBase: 90.15% // Head: 90.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
=======================================
Coverage 90.15% 90.16%
=======================================
Files 248 249 +1
Lines 14291 14299 +8
=======================================
+ Hits 12884 12892 +8
Misses 1159 1159
Partials 248 248
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/easycla |
dmitryax
approved these changes
Dec 13, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.