Skip to content

add logs filtering #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

add logs filtering #1823

merged 4 commits into from
Apr 9, 2025

Conversation

oliver-zhang
Copy link
Contributor

@oliver-zhang oliver-zhang commented Apr 1, 2025

Description:

Sometimes we don't want to collect all the logs, we only need the logs associated with the call chain, this processor only keeps logs if they have an associated span which is sample

Existing Issue(s):

NA

Testing:

FilteringLogRecordProcessorTest

Documentation:

Outstanding items:

Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think it's a nice addition 👍 I just added a comment to clarify the readme. Please run ./gradlew spotlessApply to address the CI check failures.

Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trask trask merged commit e009336 into open-telemetry:main Apr 9, 2025
18 checks passed
@oliver-zhang oliver-zhang deleted the log-filter branch April 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants