AWS Lambda Runtime legacy internal handlers need to be ignored from being instrumented and so traced … #10942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing instrumented and so traced. Otherwise, there might be double root spans.
laurit
approved these changes
Mar 25, 2024
tylerbenson
approved these changes
Mar 25, 2024
trask
approved these changes
Mar 25, 2024
...try/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaRequestHandlerInstrumentation.java
Show resolved
Hide resolved
…ain/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaRequestHandlerInstrumentation.java Co-authored-by: Trask Stalnaker <[email protected]>
|
Hi @trask, Thanks for the review, I have applied your suggestion. |
6 tasks
srprash
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Feb 3, 2025
In the [previous bugfix](#1000), we missed porting this change from OTel specifically for Java 8 and 11 runtimes. open-telemetry/opentelemetry-java-instrumentation#10942 **Testing:** Created an ADOT lambda layer with the change and verified that the duplicate lambda spans do not appear for Java 11, 17, and 21. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Otherwise, there might be double root spans.
Fixes #10931
In Java 8 and Java 11 runtimes, AWS Lambda runtime is packaged under
lambdainternalpackage (it iscom.amazonaws.services.lambda.runtime.api.clientfor new runtime likes Java 17 and Java 21)I have
/var/runtime/folder in the AWS Lambda environment for Java 8 and Java 11 runtimes,Here are the existing files:
Then I have decompiled classes from
LambdaSandboxJava-byol.jarandLambdaJavaRTEntry-byol.jar.And as you can see below, AWS Lambda runtime internal classes are packaged under
lambdainternalpackage and the internal handler (lambdainternal.EventHandlerLoader) we need to ignore is there.