Convert internal-class-loader tests from groovy to java #9560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Sep 29, 2023
There was a problem hiding this comment.
In OSGIClassloadingTest the groovy test invoked a loadClass(String, Boolean) that is not accessible in java, therefore I omitted it, but if there is another way I should approach it, please let me know and I can revisit.
You could test the 2 arg loadClass variant in ClassLoadingTest. The test class loader there extends URLClassLoader which has a public 2 arg loadClass.
...t/java/io/opentelemetry/javaagent/instrumentation/internal/classloader/ClassLoadingTest.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/internal/classloader/JbossClassloadingTest.java
Outdated
Show resolved
Hide resolved
…mentation into internal-class-loader-tests
… loadClass in ClassLoadingTest
laurit
approved these changes
Sep 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7195
Note:
OSGIClassloadingTestthe groovy test invoked aloadClass(String, Boolean)that is not accessible in java, therefore I omitted it, but if there is another way I should approach it, please let me know and I can revisit.