Skip to content

feat(test-utils): add assertion helper for faas resources #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kaspernissen
Copy link

Which problem is this PR solving?

I'm currently trying to expand the resource detector for gcp and aligning it with the rest of the gcp resource detectors in other languages, that currently sets faas.name, faas.version, and faas.instance for Cloud Run services.

I have another PR open on this topic: #2818 where I will be using this helper.

Short description of the changes

This PR adds an assertion helper to the opentelemtry-test-utils package. Similarly to the rest of the assertion helpers it uses the semantic conventions and validates the inputs.

@pichlermarc
Copy link
Member

Hi @kaspernissen - I would rather not have this be part of the @opentelemetry/contrib-test-utils unless it's commonly used across multiple packages. I think for now it would be better to have the assertion helper in @opentelemetry/resource-detector-gcp instead.

@kaspernissen
Copy link
Author

Sure, I can do that for now. Reasoning behind putting it in the common, was to make it available for other packages.
I will close this PR and add it with the original PR 👍 Thanks for your swift reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants