Skip to content
This repository was archived by the owner on May 5, 2022. It is now read-only.

Kosovo is not coloured green on the map, missing from coverage #700

Closed
stefanb opened this issue Apr 17, 2018 · 4 comments
Closed

Kosovo is not coloured green on the map, missing from coverage #700

stefanb opened this issue Apr 17, 2018 · 4 comments

Comments

@stefanb
Copy link
Contributor

stefanb commented Apr 17, 2018

After openaddresses/openaddresses#3866
was merged imports seem to be running fine:
http://results.openaddresses.io/sources/xk/countrywide
but

Perhaps there is some misalignment in the ISO country code XK vs KV ?

The map on the main page https://openaddresses.io/ is showing the addresses nicely.

Is machine respecting strictly just ISO-assigned 2-letter country codes and is not knowing either of those?

@stefanb stefanb changed the title Kosovo is not coloured green on the map Kosovo is not coloured green on the map, missing from coverage Apr 17, 2018
@migurski
Copy link
Member

I think I see the problem: our Natural Earth countries dataset does not include an ISO 2-letter code for Kosovo. I’ll fix it in our copy. /cc @nvkelso

@stefanb
Copy link
Contributor Author

stefanb commented Apr 18, 2018

It would be nice to either:

  • check for valid country code during source json validation or
  • generate a warning during batch run

stefanb added a commit to stefanb/openaddresses that referenced this issue Apr 18, 2018
@migurski
Copy link
Member

Checking for a valid code shouldn’t be too difficult. In this case you’d have received a warning that we don’t know “XK”.

@stefanb
Copy link
Contributor Author

stefanb commented Apr 23, 2018

In the coverage table on http://results.openaddresses.io/coverage/world/ there is still no sign of Kosovo.

Validating the code would make sense only if there is no geometry defined in the source json, so that machine make sure that it understands the coverage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants