Skip to content

Fix function_schema name override bug #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix function_schema name override bug #872

merged 1 commit into from
Jun 16, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Jun 15, 2025 •
edited
Loading

Summary

  • ensure name_override is always used in function_schema
  • test name override when docstring info is disabled

Testing

  • make format
  • make lint
  • make mypy
  • make tests

Resolves #860

https://chatgpt.com/codex/tasks/task_i_684f1cf885b08321b4dd3f4294e24ca2

@rm-openai rm-openai merged commit 6d2806f into main Jun 16, 2025
5 checks passed
@rm-openai rm-openai deleted the codex/fix-name_override-bug-in-function_schema branch June 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

Assignees

@pakrym-oai pakrym-oai

Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name_override not respected when use_docstring_info=False due to missing parentheses in func_name assignment in function_schema
2 participants
@rm-openai @pakrym-oai