Refactor many test suites to use testUtils/initializeMocks #2067
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bradenmacdonald
force-pushed
the
braden/modernize-tests
branch
from
cfb8e53 to
6b3a288
Compare
| @@ -175,4 +175,4 @@ CourseTeam.propTypes = { | |||
| courseId: PropTypes.string.isRequired, | |||
| }; | |||
|
|
|||
| export default injectIntl(CourseTeam); | |||
| export default CourseTeam; | |||
There was a problem hiding this comment.
OK, I did make this one tiny fix to a non-test file. But all the other changes are only in tests.
This component was using both useIntl and injectIntl and obviously only needs useIntl.
| // eslint-disable-next-line no-promise-executor-return | ||
| await new Promise((r) => setTimeout(r, 3500)); |
There was a problem hiding this comment.
A bunch of tests were using hard-coded delays/sleeps. I replaced them with waitFor which is potentially faster, though in this case still ends up waiting ~3s compared to the hard-coded 3.5s.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
==========================================
+ Coverage 93.99% 94.00% +0.01%
==========================================
Files 1154 1154
Lines 24148 24185 +37
Branches 5206 5118 -88
==========================================
+ Hits 22698 22736 +38
+ Misses 1382 1381 -1
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Looks good 👍
- I tested this:I checked the tests and I verified that the Course Team page works well
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
- Includes documentation
|
Thanks @ChrisChV ! |
Description
In preparation for an upcoming PR (related to waffle flags), this PR simplifies a bunch of test code by converting it to use our handy
testUtilsmodule.None of the app code is changed in this PR, just test code. And none of the test cases are modified in any meaningful way - this just simplifies the setup/cleanup significantly.
Supporting information
Private ref MNG-4670
Testing instructions
GitHub CI will run the tests for you - no manual testing is required.