feat: add ParentBreadcrumbs component [FC-0090] #2223

rpenido · 2025-06-25T17:44:56Z

Description

This PR adds the ParentBreadcrumbs component to show a list of parent containers on the Unit and Subsection breadcrumbs.

Supporting information

Related to Unit Pages should show breadcrumbs #2194

Testing instructions

Open a unit not associated with any subsections
Check that the breadcrumbs show only the library name
Add a unit to one subsection
Open the Unit page and check that the breadcrumbs show a direct link to this subsection
Add the same unit to another subsection
Open the Unit page and check that the breadcrumbs show a menu listing both subsections
Repeat the process, checking Subsections associated with Sections

Private ref: FAL-4216

openedx-webhooks · 2025-06-25T17:45:01Z

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-06-26T10:26:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (4905f3b) to head (42836c9).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2223      +/-   ##
==========================================
+ Coverage   94.14%   94.17%   +0.02%     
==========================================
  Files        1164     1167       +3     
  Lines       24596    24665      +69     
  Branches     5249     5379     +130     
==========================================
+ Hits        23157    23229      +72     
+ Misses       1371     1359      -12     
- Partials       68       77       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

navinkarkera

@rpenido Looks good! 👍

I tested this: (Verified breadcrumbs in unit and subsection pages)
I read through the code
I checked for accessibility issues
Includes documentation

src/library-authoring/generic/parent-breadcrumbs/index.tsx

Co-authored-by: Navin Karkera <[email protected]>

ChrisChV

Looks good 👍 Fix the nits to merge

ChrisChV · 2025-06-27T18:43:09Z

src/library-authoring/generic/parent-breadcrumbs/ParentBreadcrumbs.test.tsx

+);
+
+describe('<ParentBreadcrumbs />', () => {
+  it('show breadcrubs without parent', async () => {


Suggested change

it('show breadcrubs without parent', async () => {

it('show breadcrumb without parent', async () => {

ChrisChV · 2025-06-27T18:43:21Z

src/library-authoring/generic/parent-breadcrumbs/ParentBreadcrumbs.test.tsx

+    expect(links[1]).toHaveProperty('href', 'http://localhost/');
+  });
+
+  it('show breadcrubs to a unit without one parent', async () => {


Suggested change

it('show breadcrubs to a unit without one parent', async () => {

it('show breadcrumb to a unit without one parent', async () => {

ChrisChV · 2025-06-27T18:43:37Z

src/library-authoring/generic/parent-breadcrumbs/ParentBreadcrumbs.test.tsx

+    expect(links[1]).toHaveProperty('href', 'http://localhost/library/library-id/subsection/subsection-key');
+  });
+
+  it('show breadcrubs to a subsection without one parent', async () => {


Suggested change

it('show breadcrubs to a subsection without one parent', async () => {

it('show breadcrumb to a subsection without one parent', async () => {

ChrisChV · 2025-06-27T18:44:21Z

src/library-authoring/generic/parent-breadcrumbs/ParentBreadcrumbs.test.tsx

+    })).toThrow('Parents key and displayName arrays must have the same length.');
+  });
+
+  it('show breadcrubs with multiple parents', async () => {


Suggested change

it('show breadcrubs with multiple parents', async () => {

it('show breadcrumb with multiple parents', async () => {

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 25, 2025

openedx-webhooks added this to Contributions Jun 25, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jun 25, 2025

rpenido force-pushed the rpenido/fal-4216-unit-page-breadcrumbs branch 6 times, most recently from 951fa3e to 7d229f6 Compare June 26, 2025 09:25

rpenido changed the title ~~feat: add ParentBreadcrumbs component~~ feat: add ParentBreadcrumbs component [FC-0090] Jun 26, 2025

rpenido force-pushed the rpenido/fal-4216-unit-page-breadcrumbs branch 2 times, most recently from d280706 to 46983d3 Compare June 26, 2025 09:51

feat: add ParentBreadcrumbs component

b0647f8

rpenido force-pushed the rpenido/fal-4216-unit-page-breadcrumbs branch from 46983d3 to b0647f8 Compare June 26, 2025 09:58

fix: CI

6516b05

fix: unit dropdown title and add tests

c56ed0c

rpenido force-pushed the rpenido/fal-4216-unit-page-breadcrumbs branch from 2ad8a48 to c56ed0c Compare June 26, 2025 14:06

rpenido requested a review from navinkarkera June 26, 2025 14:20

navinkarkera approved these changes Jun 27, 2025

View reviewed changes

src/library-authoring/generic/parent-breadcrumbs/index.tsx Outdated Show resolved Hide resolved

rpenido and others added 2 commits June 27, 2025 18:02

refactor: fix from review

dde1240

Co-authored-by: Navin Karkera <[email protected]>

fix: eslint

42836c9

ChrisChV approved these changes Jun 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add ParentBreadcrumbs component [FC-0090] #2223

feat: add ParentBreadcrumbs component [FC-0090] #2223

Uh oh!

rpenido commented Jun 25, 2025 •

edited

Loading

Uh oh!

openedx-webhooks commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

navinkarkera left a comment

Uh oh!

Uh oh!

ChrisChV left a comment

Uh oh!

ChrisChV Jun 27, 2025

Uh oh!

ChrisChV Jun 27, 2025

Uh oh!

ChrisChV Jun 27, 2025

Uh oh!

ChrisChV Jun 27, 2025

Uh oh!

Uh oh!

	it('show breadcrubs without parent', async () => {
	it('show breadcrumb without parent', async () => {

	it('show breadcrubs to a unit without one parent', async () => {
	it('show breadcrumb to a unit without one parent', async () => {

	it('show breadcrubs to a subsection without one parent', async () => {
	it('show breadcrumb to a subsection without one parent', async () => {

	it('show breadcrubs with multiple parents', async () => {
	it('show breadcrumb with multiple parents', async () => {

feat: add ParentBreadcrumbs component [FC-0090] #2223

Are you sure you want to change the base?

feat: add ParentBreadcrumbs component [FC-0090] #2223

Uh oh!

Conversation

rpenido commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Uh oh!

openedx-webhooks commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChrisChV left a comment

Choose a reason for hiding this comment

Uh oh!

ChrisChV Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisChV Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisChV Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisChV Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rpenido commented Jun 25, 2025 •

edited

Loading

codecov bot commented Jun 26, 2025 •

edited

Loading