-
Notifications
You must be signed in to change notification settings - Fork 134
fix: publish button doesn't show up after component edit #2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: publish button doesn't show up after component edit #2227
Conversation
713339c
to
b185946
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2227 +/- ##
==========================================
- Coverage 94.15% 94.15% -0.01%
==========================================
Files 1164 1164
Lines 24599 24609 +10
Branches 5381 5365 -16
==========================================
+ Hits 23162 23171 +9
- Misses 1360 1370 +10
+ Partials 77 68 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
74fcbb0
to
35d4673
Compare
When we edit & save the component, publish button doesn't show up until we refresh the page manualy or open this unit by opening previous unit and coming back to this unit again. In this commit, we are dispatching a storage event whenever we edit the component, it'll refresh the page & show the publish button as expected.
35d4673
to
7534621
Compare
Should |
I tried to use react state first! But that wasn't possible due to separate store for editor from rest of the components.
Yup, Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't consider the multiple tabs. All of that makes sense to me!
Ticket: TNL-12019
When we edit & save the component, publish button doesn't show up until we refresh the page manualy or open this unit by opening previous unit and coming back to this unit again.
In this PR, we are dispatching a storage event whenever we edit the component, it'll refresh the page & show the publish button as expected.
Before:

After:
