Skip to content

feat: upgrade react to v18 #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Conversation

huniafatima-99
Copy link
Contributor

Description

This PR upgrades react from v17 to v18.

Issue link

#753

@huniafatima-99 huniafatima-99 linked an issue Mar 27, 2025 that may be closed by this pull request
@huniafatima-99 huniafatima-99 self-assigned this Mar 27, 2025
@brian-smith-tcril
Copy link
Contributor

Thanks for opening this!

Looks like CI is failing on lint at the moment. Could you run lint:fix?

@huniafatima-99 huniafatima-99 marked this pull request as draft April 7, 2025 12:30
@huniafatima-99 huniafatima-99 force-pushed the hunia/react-18-upgrade branch from 89ed5a9 to 352a154 Compare April 7, 2025 13:26
@huniafatima-99 huniafatima-99 marked this pull request as ready for review April 7, 2025 13:26
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (ff72dab) to head (3379141).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/index.jsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   93.17%   93.15%   -0.03%     
==========================================
  Files         161      161              
  Lines        3401     3402       +1     
  Branches      919      923       +4     
==========================================
  Hits         3169     3169              
  Misses        215      215              
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 7, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@huniafatima-99 huniafatima-99 enabled auto-merge (squash) April 9, 2025 11:16
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking great! I left a couple comments about changes to the tests, but once those are addressed this should be good to merge!

@brian-smith-tcril brian-smith-tcril merged commit 05cf174 into master Apr 9, 2025
4 of 6 checks passed
@brian-smith-tcril brian-smith-tcril deleted the hunia/react-18-upgrade branch April 9, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 18 Upgrade
5 participants