-
Notifications
You must be signed in to change notification settings - Fork 82
feat: upgrade react to v18 #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this! Looks like CI is failing on |
89ed5a9
to
352a154
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 93.17% 93.15% -0.03%
==========================================
Files 161 161
Lines 3401 3402 +1
Branches 919 923 +4
==========================================
Hits 3169 3169
Misses 215 215
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sandbox deployment successful 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking great! I left a couple comments about changes to the tests, but once those are addressed this should be good to merge!
Description
This PR upgrades react from v17 to v18.
Issue link
#753