This repository was archived by the owner on Nov 6, 2020. It is now read-only.
EIP #198 and Issue #185: added bn_128_add benchmark #6263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @tcsiwula hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, plesae reply to this thread with Many thanks, Parity Technologies CLA Bot |
|
[clabot:check] |
|
It looks like @tcsiwula signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
timxor
changed the title
|
Thank you for the contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Parity Team,
This pull request adds a benchmark for ethereum builtins bn_128_add for EIP#198 and Issue#185 on the metropolis-update branch.
I'm am new to this project, so I'm not yet acquainted with the formalities around ensuring that all the tests pass etc., however I'm enthusiastic about contributing. So if someone would be interested in helping me enhance the quality of this pull request, I would love to speak with you~
Thank you =)
Tim (@tcsiwula)