(#38) Update project and vpc modules to TF 13 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmccune
force-pushed
the
jm/38_tf13
branch
from
aa42f3b to
fad033c
Compare
Apply these versions with TF 0.12 and then TF 0.13 to avoid the
following error.
```
Error: Provider configuration not present
To work with
module.host.module.project.module.project-factory.null_resource.preconditions
its original provider configuration at
provider["registry.terraform.io/-/null"] is required, but it has been removed.
This occurs when a provider configuration is removed while objects created by
that provider still exist in the state. Re-add the provider configuration to
destroy
module.host.module.project.module.project-factory.null_resource.preconditions,
after which you can remove the provider configuration again.
```
Changes are expected:
```
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
- destroy
Terraform will perform the following actions:
# module.host.module.project.module.project-factory.null_resource.preconditions will be destroyed
- resource "null_resource" "preconditions" {
- id = "8839499245402532934" -> null
- triggers = {
- "billing_account" = "XXXXXXXXXXXXXXXXXXXX"
- "credentials_path" = ""
- "folder_id" = "folders/XXXXXXXXXXXX"
- "org_id" = "XXXXXXXXXXXX"
- "shared_vpc" = ""
} -> null
}
Plan: 0 to add, 0 to change, 1 to destroy.
Do you want to perform these actions in workspace "dev"?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
Enter a value: yes
module.host.module.project.module.project-factory.null_resource.preconditions: Destroying... [id=8839499245402532934]
module.host.module.project.module.project-factory.null_resource.preconditions: Destruction complete after 0s
```
Also run `terraform 0.13upgrade` to generate version information.
jeffmccune
force-pushed
the
jm/38_tf13
branch
from
bc4620a to
a2a785b
Compare
Without this patch autoscaling is enabled even when running `num_instances=0` with the multiregion example.
Fix the following warning with 0.13.6
```
Warning: Interpolation-only expressions are deprecated
on ../../modules/50_compute/main.tf line 33, in data "template_file" "startup-script-config":
33: template = "${file("${path.module}/templates/startup-script-config.tpl")}"
Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.
Template interpolation syntax is still used to construct strings from
expressions when the template includes multiple interpolation sequences or a
mixture of literal strings and interpolations. This deprecation applies only
to templates that consist entirely of a single interpolation sequence.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upgrades the CFT Project Factory and Network modules for use
with Terraform 13.
Closes: #38