8355003: Implement Ahead-of-Time Method Profiling #24886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

veresov wants to merge 28 commits into openjdk:master from veresov:pp2

+3,132 −221

Contributor

veresov commented Apr 25, 2025 •

edited by openjdk bot

Loading

Improve warm-up time by making profile data from a previous run of an application instantly available, when the HotSpot Java Virtual Machine starts. Specifically, enhance the AOT cache to store method execution profiles from training runs, reducing profiling delays in subsequent production runs.

More details in the JEP: https://bugs.openjdk.org/browse/JDK-8325147

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8355003: Implement Ahead-of-Time Method Profiling (Sub-task - P4)

Contributors

John R Rose <[email protected]>
Vladimir Ivanov <[email protected]>
Ioi Lam <[email protected]>
Vladimir Kozlov <[email protected]>
Aleksey Shipilev <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24886/head:pull/24886
$ git checkout pull/24886

Update a local copy of the PR:
$ git checkout pull/24886
$ git pull https://git.openjdk.org/jdk.git pull/24886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24886

View PR using the GUI difftool:
$ git pr show -t 24886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24886.diff

Using Webrev

Link to Webrev Comment

veresov added 28 commits

March 24, 2025 15:54


          Persistent profiles initial commit


          Fix copyright

f1214b9


          Fix whitespaces

5a0ada5


          Fix comment

60d7908


          Address Ioi's comments

c55c36c


          Review changes part 1

cb67f76


          Remove MethodData::__gap

11551f2


          Port tagged pointers support

a372407


          Port Ioi's follow up change

2af06b4


          Merge branch 'master' into pp

ebe8748


          Merge branch 'master' into pp

c504214


          Port 8354330: [leyden] Crash inside AdapterHandlerEntry::metaspace_po…

5daecb0

…inters_do


          Remove unused function

a5ad4af


          Merge branch 'master' into pp

63a4e66


          Rename flags and move them to cds_globals.hpp

283ed99


          Update MTD::_hightest_top_level only after successful CTD allocation

35b7e00


          Fix include order

35fa04c


          Port servicibility changes

bcf31d4


          Don't compile trainingData.cpp without CDS (part 1)

d40cee2


          Don't compile trainingData.cpp without CDS (part 2)

cfe7381


          Add test

0b7a2dc


          Fix value of CompLevel_count

593c394


          Missing part of the last commit

6fad35c


          Use ENABLE_IF macro

4e6397a


          Port 8355296: [leyden] Some methods are stuck at level=0 with -XX:-Ti…

585bdda

…eredCompilation


          Port 8355334: [leyden] Missing type profile info in archived training…

84959bc

… data


          Add AOTCompileEagerly flag to control compilation after clinit

fa1ef0f


          Merge branch 'master' into pp

3ec132e

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk bot added the rfr label

openjdk bot commented Apr 25, 2025

@veresov The following labels will be automatically applied to this pull request:

build
hotspot
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk bot added serviceability build hotspot labels

Contributor Author

veresov commented Apr 25, 2025

/label hotspot-compiler
/label hotspot-runtime

openjdk bot added the hotspot-compiler label

openjdk bot commented Apr 25, 2025

@veresov
The hotspot-compiler label was successfully added.

openjdk bot added the hotspot-runtime label

openjdk bot commented Apr 25, 2025

@veresov
The hotspot-runtime label was successfully added.

Contributor Author

veresov commented Apr 25, 2025

/contributor jrose
/contributor vlivanov
/contributor iklam
/contributor kvn
/contributor shade

openjdk bot commented Apr 25, 2025

@veresov Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk bot commented Apr 25, 2025

@veresov Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk bot commented Apr 25, 2025

@veresov Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk bot commented Apr 25, 2025

@veresov Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

openjdk bot commented Apr 25, 2025

@veresov Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <[email protected]>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

Contributor Author

veresov commented Apr 25, 2025

/contributor add jrose
/contributor add vlivanov
/contributor add iklam
/contributor add kvn
/contributor add shade

openjdk bot commented Apr 25, 2025

@veresov
Contributor John R Rose <[email protected]> successfully added.

openjdk bot commented Apr 25, 2025

@veresov
Contributor Vladimir Ivanov <[email protected]> successfully added.

openjdk bot commented Apr 25, 2025

@veresov
Contributor Ioi Lam <[email protected]> successfully added.

openjdk bot commented Apr 25, 2025

@veresov
Contributor Vladimir Kozlov <[email protected]> successfully added.

openjdk bot commented Apr 25, 2025

@veresov
Contributor Aleksey Shipilev <[email protected]> successfully added.

mlbridge bot commented Apr 25, 2025

Webrevs

00: Full (3ec132e7)

vnkozlov suggested changes

View reviewed changes

Contributor

vnkozlov left a comment

In general it is okay.

Please, use UL with (aot, training) tags for your code.

I noticed (and added comment) that you use guarantee() which crashes VM when you call new verify methods. Can you disable TD instead and continue execution?

test/hotspot/jtreg/runtime/cds/appcds/aotProfile/AOTProfileFlags.java

+               * @summary Sanity test of combinations of the diagnostic flags [+-]AOTRecordTraining and [+-]AOTReplayTraining
+               * @requires vm.cds
+               * @comment work around JDK-8345635
+               * @requires !vm.jvmci.enabled

Contributor

vnkozlov Apr 26, 2025

Consider adding:

 * @requires vm.cds.supports.aot.class.linking
 * @requires vm.flagless

Contributor Author

veresov Apr 26, 2025

Could you please explain why? @iklam, what do you think?

Member

iklam Apr 27, 2025

I think it's OK to test without these two additional flags. This will make sure that the two diagnostic flags don't have any bad side effect even if AOT class linking is disabled (due to flags like -XX:+UseZGC).

Contributor

vnkozlov Apr 27, 2025

I see them in aotClassLinking/AOTClassLinkingVMOptions.java test.
@veresov please, add link to your mach5 testing to JBS. And add to description what tests you already ran.

Member

iklam Apr 27, 2025

OK, let's add those two @requires to be consistent with other tests.

src/hotspot/share/runtime/init.cpp Show resolved Hide resolved

src/hotspot/share/oops/methodData.cpp

               }
               void MethodData::metaspace_pointers_do(MetaspaceClosure* it) {
-                log_trace(cds)("Iter(MethodData): %p", this);
+                log_trace(cds)("Iter(MethodData): %p for %p %s", this, _method, _method->name_and_sig_as_C_string());

Contributor

vnkozlov Apr 26, 2025

We discussed yesterday and we need to use aot instead cds for Leyden. aot tag is already in mainline.
I suggest to use new tag (aot, training) to separate your output from general CDS/AOT output.

src/hotspot/share/oops/methodData.cpp Show resolved Hide resolved

src/hotspot/share/oops/methodData.cpp Show resolved Hide resolved

src/hotspot/share/cds/archiveBuilder.cpp

    
            @@ -739,6 +767,10 @@ void ArchiveBuilder::relocate_metaspaceobj_embedded_pointers() {
          
                log_info(cds)("Relocating embedded pointers in core regions ... ");

                relocate_embedded_pointers(&_rw_src_objs);

                relocate_embedded_pointers(&_ro_src_objs);

                log_info(cds)("Relocating %zu pointers, %zu tagged, %zu nulled",

Contributor

vnkozlov Apr 26, 2025

log_info(aot) if it is Leyden related.

src/hotspot/share/oops/trainingData.cpp Show resolved Hide resolved

src/hotspot/share/oops/trainingData.cpp Show resolved Hide resolved

src/hotspot/share/oops/trainingData.cpp Show resolved Hide resolved

src/hotspot/share/oops/trainingData.cpp

    
                  bool is_excluded = !holder()->is_loaded() || SystemDictionaryShared::check_for_exclusion(holder(), nullptr);

                  if (is_excluded) {

                    ResourceMark rm;

                    log_debug(cds)("Cleanup KTD %s", name()->as_klass_external_name());

Contributor

vnkozlov Apr 26, 2025

log_debug(aot, training)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build hotspot hotspot-compiler hotspot-runtime rfr serviceability