8355372: GenShen: Test gc/shenandoah/generational/TestOldGrowthTriggers.java fails with UseCompactObjectHeaders enabled #24888
Conversation
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Looks fine but left some thoughts, although you probably don't want to change anything if this setting is working to induce the behavior you want to test.
A whitebox test may be better in the future rather than having to tweak test settings to induce the right behavior to trigger old growth.
| case 0: | ||
| // 50% chance of creating garbage | ||
| array[replaceIndex] = array[replaceIndex].max(array[deriveIndex]); | ||
| break; | ||
| case 1: | ||
| // 50% chance of creating garbage | ||
| array[replaceIndex] = array[replaceIndex].min(array[deriveIndex]); | ||
| break; |
There was a problem hiding this comment.
Could you have left this in place & reduced the heap size of the UseCompactHeaders test to half the current setting to induce the trigger?
| @@ -58,14 +58,6 @@ public static void makeOldAllocations() { | |||
| int replaceIndex = r.nextInt(ArraySize); | |||
| int deriveIndex = r.nextInt(ArraySize); | |||
| switch (i & 0x3) { | |||
There was a problem hiding this comment.
...otherwise could you just do (i & 0x1) here and change cases 2 & 3 to cases 0 & 1?
Add a test case for
-XX:+UseCompactObjectHeaders, increase pressure on old generation. I ran the test (which includes a compact object headers case now) fifty times without failure.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24888/head:pull/24888$ git checkout pull/24888Update a local copy of the PR:
$ git checkout pull/24888$ git pull https://git.openjdk.org/jdk.git pull/24888/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24888View PR using the GUI difftool:
$ git pr show -t 24888Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24888.diff
Using Webrev
Link to Webrev Comment