8359709: java.net.HttpURLConnection sends unexpected "Host" request header in some cases after JDK-8344190

[jaikiran]

Can I please get a review of this backport to JDK 25 for https://bugs.openjdk.org/browse/JDK-8359709? This fix addresses a regression that was introduced in JDK 24. The mainline fix was integrated a few mintues back through #25844.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359709: java.net.HttpURLConnection sends unexpected "Host" request header in some cases after JDK-8344190 (Bug - P2)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25867/head:pull/25867
$ git checkout pull/25867

Update a local copy of the PR:
$ git checkout pull/25867
$ git pull https://git.openjdk.org/jdk.git pull/25867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25867

View PR using the GUI difftool:
$ git pr show -t 25867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25867.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359709: java.net.HttpURLConnection sends unexpected "Host" request header in some cases after JDK-8344190

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk25 branch:

• 3f6b0c6: 8359386: Fix incorrect value for max_size of C2CodeStub when APX is used
• 36b185a: 8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp
• c832f00: 8359593: JFR: Instrumentation of java.lang.String corrupts recording
• ... and 2 more: https://git.openjdk.org/jdk/compare/5bcea92eaa278f632be1fd7de91b57bce46e6680...jdk25

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bb30f4a6)

[dfuch]

LGTM. This fixes a regression so should be fine to backport to 25 in RDP 1.

[jaikiran]

Thank you Daniel for the review. tier1, tier2 and tier3 of this change against JDK 25 went fine without any failures. I'll need your "Approval" on this PR to integrate it.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 41928ae.
Since your change was applied there have been 5 commits pushed to the jdk25 branch:

• 3f6b0c6: 8359386: Fix incorrect value for max_size of C2CodeStub when APX is used
• 36b185a: 8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp
• c832f00: 8359593: JFR: Instrumentation of java.lang.String corrupts recording
• ... and 2 more: https://git.openjdk.org/jdk/compare/5bcea92eaa278f632be1fd7de91b57bce46e6680...jdk25

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 41928ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.