-
Notifications
You must be signed in to change notification settings - Fork 6k
8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met #25879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…sitive result on headless machines
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
I don't understand how what you changed related to the stated problem. In fact I don't see the point of this PR at all. |
Sorry @prrace, my earlier description was ambiguous. I have updated it. In fact, the issue is about reporting a false positive 'PASSED' result when it should return a 'SKIPPED' result if the preconditions for running the test are not met. |
Issue:
MyanmarTextTest.java produces a false positive result when some of the test preconditions are not met. It checks whether certain fonts are present in the system, for example, 'Padauk' on Linux. If the required font is missing, the test simply returns early, and the test ends up passing, which is incorrect. Ideally, it should throw a jtreg.SkippedException when the necessary preconditions are not satisfied.
Another scenario is that the test passes on headless machines even though it creates GUI components. Ideally, when GUI components are created in code running on a headless machine, a HeadlessException should be thrown. However, since MyanmarTextTest.java exits before reaching the point where the GUI is created (due to unmet preconditions), it incorrectly reports a pass. This behavior may lead to a misinterpretation of the test as being headless, which it is not.
Fix:
Need to throw jtreg.SkippedException in cases where some pre-conditions for running the test are not met.
Testing:
Tested using mach5 in all available platforms and got full PASS.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25879/head:pull/25879
$ git checkout pull/25879
Update a local copy of the PR:
$ git checkout pull/25879
$ git pull https://git.openjdk.org/jdk.git pull/25879/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25879
View PR using the GUI difftool:
$ git pr show -t 25879
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25879.diff
Using Webrev
Link to Webrev Comment