Skip to content

8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met #25879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Jun 18, 2025

Issue:
MyanmarTextTest.java produces a false positive result when some of the test preconditions are not met. It checks whether certain fonts are present in the system, for example, 'Padauk' on Linux. If the required font is missing, the test simply returns early, and the test ends up passing, which is incorrect. Ideally, it should throw a jtreg.SkippedException when the necessary preconditions are not satisfied.

Another scenario is that the test passes on headless machines even though it creates GUI components. Ideally, when GUI components are created in code running on a headless machine, a HeadlessException should be thrown. However, since MyanmarTextTest.java exits before reaching the point where the GUI is created (due to unmet preconditions), it incorrectly reports a pass. This behavior may lead to a misinterpretation of the test as being headless, which it is not.

Fix:
Need to throw jtreg.SkippedException in cases where some pre-conditions for running the test are not met.

Testing:
Tested using mach5 in all available platforms and got full PASS.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25879/head:pull/25879
$ git checkout pull/25879

Update a local copy of the PR:
$ git checkout pull/25879
$ git pull https://git.openjdk.org/jdk.git pull/25879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25879

View PR using the GUI difftool:
$ git pr show -t 25879

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25879.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@prrace
Copy link
Contributor

prrace commented Jun 18, 2025

I don't understand how what you changed related to the stated problem. In fact I don't see the point of this PR at all.

@manukumarvs manukumarvs changed the title 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result on headless machines 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met Jun 18, 2025
@manukumarvs
Copy link
Member Author

I don't understand how what you changed related to the stated problem. In fact I don't see the point of this PR at all.

Sorry @prrace, my earlier description was ambiguous. I have updated it. In fact, the issue is about reporting a false positive 'PASSED' result when it should return a 'SKIPPED' result if the preconditions for running the test are not met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants