Skip to content

8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees #25887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 18, 2025

JDK-8333117 removed support for non-local debuggees, so now only local debuggees are supported. However, there are now a lot of references to the "local" debuggee mode which are not necessary because "local" is implied. These references are in comments and API names and should be removed.

Also, after JDK-8333117, DebugeeProcess no longer needs to be considered abstract. It has no abstract methods.

Tested nsk/jdi, nsk/jdb, and nsk/jdwp locally. Will run tier5 CI to get better coverage.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25887/head:pull/25887
$ git checkout pull/25887

Update a local copy of the PR:
$ git checkout pull/25887
$ git pull https://git.openjdk.org/jdk.git pull/25887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25887

View PR using the GUI difftool:
$ git pr show -t 25887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8333117 8333117: Remove support of remote and manual debuggee launchers Jun 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@plummercj plummercj changed the title 8333117: Remove support of remote and manual debuggee launchers 8359958 Jun 18, 2025
@openjdk openjdk bot changed the title 8359958 8359958: Cleanup "local" debuggee references after JDK-8333117 removed support for non-local debuggees Jun 18, 2025
@plummercj
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@plummercj The pull request is being re-evaluated and the inactivity timeout has been reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant