Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

8332880: JFR GCHelper class recognizes "Archive" regions as valid #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented Jul 1, 2024

Hi all,

This pull request contains a backport JDK-8332880 from the openjdk/jdk repository.

The commit being backported was authored by
Thomas Schatzl on 29 May 2024 and was reviewed by Albert Mingkun Yang and Ivan Walulya.

The patch applies cleanly.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332880 needs maintainer approval

Issue

  • JDK-8332880: JFR GCHelper class recognizes "Archive" regions as valid (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/252/head:pull/252
$ git checkout pull/252

Update a local copy of the PR:
$ git checkout pull/252
$ git pull https://git.openjdk.org/jdk22u.git pull/252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 252

View PR using the GUI difftool:
$ git pr show -t 252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/252.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2024

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2cca83bc82eb6b090ae96b8c072b986b93d9244a 8332880: JFR GCHelper class recognizes "Archive" regions as valid Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

This backport pull request has now been updated with issue from the original commit.

@walulyai walulyai marked this pull request as ready for review July 1, 2024 13:10
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

⚠️ @walulyai This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024

Webrevs

@walulyai
Copy link
Member Author

walulyai commented Jul 1, 2024

/approval

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@walulyai usage: /approval [<id>] (request|cancel) [<text>]

@walulyai
Copy link
Member Author

walulyai commented Jul 1, 2024

/approval request Clean backport to remove "Archive" regions from the possible types of the heap region type change events. Risk is very low.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@walulyai
8332880: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant