test: add locale assertions for middleware handling #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
added
the
test all versions
pieh
commented
Jun 30, 2025
Comment on lines
-20
to
+25
| const rewriteUrl = new URL( | ||
| url.pathname.replace('/link/rewrite-me', '/link/rewrite-target'), | ||
| url, | ||
| ) | ||
| return NextResponse.rewrite(rewriteUrl, { | ||
| // use NextUrl to rewrite the URL as it does preserve the locale | ||
| url.pathname = url.pathname.replace('/link/rewrite-me', '/link/rewrite-target') | ||
| return NextResponse.rewrite(url, { |
There was a problem hiding this comment.
Note: previous rewrite was just losing locale url due to using just NextURL.pathname to construct new URL effectively losing locale context in the process.
This change keeps using NextURL and just mutate pathname portion of it which preserve locale context and resulting in working as expected rewrites
pieh
commented
Jun 30, 2025
| @@ -63,11 +63,13 @@ test.describe('json data', () => { | |||
| describeLabel: 'NextResponse.next() -> getServerSideProps page', | |||
| selector: 'NextResponse.next()#getServerSideProps', | |||
| jsonPathMatcher: '/link/next-getserversideprops.json', | |||
| assertLocale: true, | |||
There was a problem hiding this comment.
Only getServerSideProps and getStaticProps even have access to locale and "fully static page" cases just don't have access to it so asserting locale is optional check enabled to cases when locale is even available to check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal
#2973
https://linear.app/netlify/issue/FRB-1919/version-5113-doesnt-seem-to-pass-the-correct-locale-anymore-from