Description
Describe the bug
When working on the backport PR #10479, I found that the two test methods testParseUsingPipelineStore
and innerTestParseWithProvidedPipeline
never run in both main and 2.x branch, but run normally in 1.x branch, it seems that relates to the previous PR #2491 which changed the private method innerTestParseWithProvidedPipeline
to public but maybe because the method name doesn't start with test
so this method never runs, and also relates to PR #2239 which changed the private method innerTestParseUsingPipelineStore
to public, renamed the method name but didn't remove the input parameter, so the new method testParseUsingPipelineStore
also never runs.
Here are the detail of the related changes:
innerTestParseWithProvidedPipeline
To Reproduce
Run SimulatePipelineRequestParsingTests
, you can see that only four methods are executed, testParseUsingPipelineStore
and innerTestParseWithProvidedPipeline
never run.
Expected behavior
Enable the two test methods.
Host/Environment (please complete the following information):
- OS: [macOS]
- Version [3.0]