Change priority for scheduling reroute during timeout #16445
Conversation
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 5e83a92: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/ShardsBatchGatewayAllocator.java
Outdated
Show resolved
Hide resolved
Updated |
Signed-off-by: Rishab Nahata <[email protected]>
imRishN
requested review from
anasalkouz,
andrross,
ashking94,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 6a448d0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for f29d380: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 57a8686: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 57a8686: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 57a8686: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 4696885: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16445-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36d798cc42c473bdb49f4bf39093dd3dd9191b70
# Push it to GitHub
git push --set-upstream origin backport/backport-16445-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
…ject#16445) Signed-off-by: Rishab Nahata <[email protected]>
|
❌ Gradle check result for 57a8686: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ject#16445) * Change priority for scheduling reroute in timeout Signed-off-by: Rishab Nahata <[email protected]> * Add setting for ESA Signed-off-by: Rishab Nahata <[email protected]> * Fix tests Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Add test Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Add changelog Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> --------- Signed-off-by: Rishab Nahata <[email protected]>
…16445) (#17622) * Change priority for scheduling reroute during timeout (#16445) Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> * Trigger Build Signed-off-by: Rishab Nahata <[email protected]> --------- Signed-off-by: Rishab Nahata <[email protected]>
Description
This PR updates the priority of scheduling reroute when timed out from HIGH to NORMAL. This is because consistent HIGH reroutes might starve NORMAL priority tasks. And moreover, NORMAL is right for reasonable clusters. For clusters in messed up state which is causing NORMAL priority tasks to starve, we add a new dynamic cluster setting to raise the priority of reroute task to allocate shards in such scenarios.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.