-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add File Interceptor and Integ Tests #17760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File Interceptor and Integ Tests #17760
Conversation
❌ Gradle check result for b23652b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/resources/org/opensearch/index/translog/test.policy
Outdated
Show resolved
Hide resolved
libs/agent-sm/agent/src/test/java/org/opensearch/javaagent/FileInterceptorIntegTests.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17760 +/- ##
============================================
- Coverage 72.35% 72.33% -0.02%
+ Complexity 66054 66035 -19
============================================
Files 5358 5359 +1
Lines 306485 306522 +37
Branches 44406 44421 +15
============================================
- Hits 221763 221736 -27
- Misses 66538 66662 +124
+ Partials 18184 18124 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b2f6dfd
to
a0b39b6
Compare
586d65e
to
ccc599b
Compare
Signed-off-by: Rajat Gupta <[email protected]>
3a704d6
to
63cc7c2
Compare
❌ Gradle check result for 63cc7c2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rajat Gupta <[email protected]>
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/Agent.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/Agent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for a7c48a8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andriy Redko <[email protected]>
❕ Gradle check result for 1fff2f0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/Agent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rajat Gupta <[email protected]>
❕ Gradle check result for 101cd26: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RajatGupta02 , @kumargu , I think this is good start, there are quite a few other file related APIs but we could target them later on
LGTM. thanks! |
Agreed. The model is pretty extensible. |
Description
Implements File Interceptor and adds integration tests for it.
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.