Skip to content

Add File Interceptor and Integ Tests #17760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RajatGupta02
Copy link
Contributor

@RajatGupta02 RajatGupta02 commented Apr 2, 2025

Description

Implements File Interceptor and adds integration tests for it.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RajatGupta02 RajatGupta02 changed the title File integration tests Add File Interceptor and Integ Tests Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

❌ Gradle check result for b23652b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ Gradle check result for 99a4d05: SUCCESS

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (5ec96c5) to head (101cd26).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/javaagent/FileInterceptor.java 0.00% 30 Missing ⚠️
.../src/main/java/org/opensearch/javaagent/Agent.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17760      +/-   ##
============================================
- Coverage     72.35%   72.33%   -0.02%     
+ Complexity    66054    66035      -19     
============================================
  Files          5358     5359       +1     
  Lines        306485   306522      +37     
  Branches      44406    44421      +15     
============================================
- Hits         221763   221736      -27     
- Misses        66538    66662     +124     
+ Partials      18184    18124      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RajatGupta02 RajatGupta02 force-pushed the file-integration-tests branch from 586d65e to ccc599b Compare April 4, 2025 07:09
Signed-off-by: Rajat Gupta <[email protected]>
@RajatGupta02 RajatGupta02 force-pushed the file-integration-tests branch from 3a704d6 to 63cc7c2 Compare April 4, 2025 07:54
Copy link
Contributor

github-actions bot commented Apr 4, 2025

❌ Gradle check result for 63cc7c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 4, 2025

✅ Gradle check result for bddb108: SUCCESS

Copy link
Contributor

github-actions bot commented Apr 5, 2025

❌ Gradle check result for a7c48a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 5, 2025

❕ Gradle check result for 1fff2f0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Apr 6, 2025

❕ Gradle check result for 101cd26: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RajatGupta02 , @kumargu , I think this is good start, there are quite a few other file related APIs but we could target them later on

@reta
Copy link
Contributor

reta commented Apr 6, 2025

@andrross @kumargu LGTY? thanks!

@kumargu
Copy link
Contributor

kumargu commented Apr 6, 2025

LGTM. thanks!

@kumargu
Copy link
Contributor

kumargu commented Apr 6, 2025

here are quite a few other file related APIs but we could target them later one

Agreed. The model is pretty extensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants