-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[rule based autotagging] Add Create Rule API Logic #17792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rule based autotagging] Add Create Rule API Logic #17792
Conversation
454afcf
to
90e2b4c
Compare
❌ Gradle check result for 90e2b4c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
90e2b4c
to
85ea24e
Compare
❌ Gradle check result for 85ea24e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
85ea24e
to
e215963
Compare
❌ Gradle check result for e215963: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
modify based on comments Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Lingxi Chen <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
…tion Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]>
023b4d0
to
778645c
Compare
...mons/common/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17792-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4d6f8bafe489bde867b783c6facd189657ec34e6
# Push it to GitHub
git push --set-upstream origin backport/backport-17792-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Removed the stale backport 2.x label! |
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
…t#17792) Signed-off-by: Ruirui Zhang <[email protected]> --------- Co-authored-by: Lingxi Chen <[email protected]>
Description
This PR introduces the create Rule API Logic.
An exampe API request is:
And the return would be
Rule Schema PR:
#17238
RFC:
#16797
Check List