[Pull-based ingestion] make maxPollSize and pollTimeout in IngestionSource configurable #17863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yupeng9
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
bugmakerrrrrr,
jainankitk and
linuxpi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17863 +/- ##
============================================
+ Coverage 72.44% 72.49% +0.05%
- Complexity 66483 66545 +62
============================================
Files 5409 5409
Lines 308282 308276 -6
Branches 44759 44750 -9
============================================
+ Hits 223344 223494 +150
+ Misses 66608 66541 -67
+ Partials 18330 18241 -89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mch2
reviewed
Apr 9, 2025
server/src/main/java/org/opensearch/cluster/metadata/IngestionSource.java
Outdated
Show resolved
Hide resolved
mch2
approved these changes
Apr 9, 2025
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
|
❕ Gradle check result for 51dfaf8: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
mch2
approved these changes
Apr 9, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Apr 15, 2025
…ource configurable (opensearch-project#17863) * make maxPollSize and pollTimeout in IngestionSource configurable Signed-off-by: Yupeng Fu <[email protected]> * changelog Signed-off-by: Yupeng Fu <[email protected]> * comment Signed-off-by: Yupeng Fu <[email protected]> --------- Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…ource configurable (opensearch-project#17863) * make maxPollSize and pollTimeout in IngestionSource configurable Signed-off-by: Yupeng Fu <[email protected]> * changelog Signed-off-by: Yupeng Fu <[email protected]> * comment Signed-off-by: Yupeng Fu <[email protected]> --------- Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…ource configurable (opensearch-project#17863) * make maxPollSize and pollTimeout in IngestionSource configurable Signed-off-by: Yupeng Fu <[email protected]> * changelog Signed-off-by: Yupeng Fu <[email protected]> * comment Signed-off-by: Yupeng Fu <[email protected]> --------- Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow maxPollSize and pollTimeout in IngestionSource to be configurable
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.