Fix javaagent arg when running in IntelliJ #17886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking the summary from my conversation with Claude to fix this: 1. We needed afterEvaluate to ensure the project was fully configured before accessing its properties 2. The correct path was in build/distributions rather than build/libs 3. We had to properly handle Gradle's Provider API when constructing the path 4. The jar name needed to include both the archivesName and the project version Signed-off-by: Michael Froh <[email protected]>
msfroh
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
1 task
66 tasks
|
❕ Gradle check result for 70c774b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17886 +/- ##
============================================
+ Coverage 72.43% 72.47% +0.03%
- Complexity 66789 66809 +20
============================================
Files 5449 5451 +2
Lines 309085 309146 +61
Branches 44979 44988 +9
============================================
+ Hits 223899 224041 +142
+ Misses 66906 66784 -122
- Partials 18280 18321 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
owaiskazi19
approved these changes
Apr 10, 2025
This was referenced Apr 11, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Apr 15, 2025
Taking the summary from my conversation with Claude to fix this: 1. We needed afterEvaluate to ensure the project was fully configured before accessing its properties 2. The correct path was in build/distributions rather than build/libs 3. We had to properly handle Gradle's Provider API when constructing the path 4. The jar name needed to include both the archivesName and the project version Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Taking the summary from my conversation with Claude to fix this: 1. We needed afterEvaluate to ensure the project was fully configured before accessing its properties 2. The correct path was in build/distributions rather than build/libs 3. We had to properly handle Gradle's Provider API when constructing the path 4. The jar name needed to include both the archivesName and the project version Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
Taking the summary from my conversation with Claude to fix this: 1. We needed afterEvaluate to ensure the project was fully configured before accessing its properties 2. The correct path was in build/distributions rather than build/libs 3. We had to properly handle Gradle's Provider API when constructing the path 4. The jar name needed to include both the archivesName and the project version Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking the summary from my conversation with Claude to fix this:
Related Issues
Resolves #17883
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.