Skip to content

[GRPC] Update GRPC APIs to use latest opensearch-protobufs:0.3.0 jar and various javadocs fixes #17895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025

Conversation

karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Apr 10, 2025

This PR is a prerequisite for #17888.

Description

  1. Pull in latest protobuf changes (opensearch-project/opensearch-protobufs@0.2.0...0.3.0 ) -> which consequently required a bunch of changes to existing document APIs to compile properly
  2. Fix some java docs in plugins/transport-grpc

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#16783
#16784

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx karenyrx marked this pull request as ready for review April 10, 2025 23:45
@karenyrx karenyrx changed the title [GRPC] Refactor GRPC APIs to use opensearch-protobufs:0.3.0 jar and fix some java docs [GRPC] Update GRPC APIs to use latest opensearch-protobufs:0.3.0 jar and various javadocs fixes Apr 10, 2025
Copy link
Contributor

❌ Gradle check result for 190448a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 190448a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (1628152) to head (dab222f).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...ponse/document/common/DocumentFieldProtoUtils.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17895      +/-   ##
============================================
+ Coverage     72.43%   72.49%   +0.05%     
- Complexity    66789    66792       +3     
============================================
  Files          5449     5454       +5     
  Lines        309085   309119      +34     
  Branches      44979    44984       +5     
============================================
+ Hits         223899   224084     +185     
+ Misses        66906    66727     -179     
- Partials      18280    18308      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen Xu <[email protected]>
Copy link
Contributor

❌ Gradle check result for d7f48ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen Xu <[email protected]>
Copy link
Contributor

❌ Gradle check result for dab222f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for dab222f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit a4bc4bf into opensearch-project:main Apr 11, 2025
31 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Apr 15, 2025
…and various javadocs fixes (opensearch-project#17895)

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Sriram Ganesh <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…and various javadocs fixes (opensearch-project#17895)

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…and various javadocs fixes (opensearch-project#17895)

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants