-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Create thread id to SourceLookup map #17927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for 501d8f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
By adding new API we are not preventing any other usage of the existing API to fall into the same trap and the assumption here is that this FieldScript will only be used in the fetch phase. Instead as discussed, lets add the map with threadId to |
❌ Gradle check result for eea1ced: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9248b29: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c0f5565: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Gradle check failing on this:
|
I'm a little confused on this one as the mockito version we're on (5.16) is supposed to be able to mock final classes. Will go with an alternative approach for now while I look into that. |
Signed-off-by: Jay Deng <[email protected]>
❕ Gradle check result for 42ae9a0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit a06cf2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a06cf2c) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…pensearch-project#18107) (cherry picked from commit a06cf2c) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <[email protected]>
Description
This PR includes changes to retrieve SourceLookup based on the current thread id. See #17743 (comment) for more details.
Testing
This PR includes new test coverage on the cache case, as well as the existing scripting tests passing.
More broadly we need to invest in better perf testing related to scripting: opensearch-project/opensearch-benchmark-workloads#362
Related Issues
Relates #17743
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.