Skip to content

[Backport 3.0] Limit stack walking to frames before AccessController.doPrivileged #18029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

andrross
Copy link
Member

Parallel backport of fix from #17894

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for 438868a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.0@d18982c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ent/StackCallerProtectionDomainChainExtractor.java 0.00% 4 Missing ⚠️
...opensearch/javaagent/SocketChannelInterceptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             3.0   #18029   +/-   ##
======================================
  Coverage       ?   72.53%           
  Complexity     ?    67079           
======================================
  Files          ?     5478           
  Lines          ?   310034           
  Branches       ?    45066           
======================================
  Hits           ?   224883           
  Misses         ?    66819           
  Partials       ?    18332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross
Copy link
Member Author

andrross commented Apr 22, 2025

The "detect breaking changes" failure is due to a misconfigured action for this branch. See #18030

The precommit/assemble actions for JDK 11 and 17 need to be removed as well because they are not supported in 3.0.

All other tests/checks have passed.

@andrross andrross merged commit c57c9d3 into opensearch-project:3.0 Apr 22, 2025
58 of 59 checks passed
@andrross andrross deleted the backport-stack-walk-limit branch April 22, 2025 19:06
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…pensearch-project#18029)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants