Skip to content

Increase Kafka topic polling time in test to 10 seconds #18040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

andrross
Copy link
Member

We've seen multiple failures where the 3 second timeout was breached. This happens in the test setup of many different tests so multiple individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other code paths.

Resolves #17215

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

Signed-off-by: Andrew Ross <[email protected]>
Copy link
Contributor

✅ Gradle check result for 284c18d: SUCCESS

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (6afec2a) to head (284c18d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18040      +/-   ##
============================================
- Coverage     72.57%   72.50%   -0.07%     
+ Complexity    67160    67101      -59     
============================================
  Files          5478     5478              
  Lines        310130   310132       +2     
  Branches      45087    45087              
============================================
- Hits         225068   224860     -208     
- Misses        66661    66957     +296     
+ Partials      18401    18315      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 54e02a7 into opensearch-project:main Apr 23, 2025
56 of 57 checks passed
@andrross andrross deleted the kafka-polling-time branch April 23, 2025 00:30
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2025
We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 54e02a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Apr 23, 2025
)

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.


(cherry picked from commit 54e02a7)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
…roject#18040)

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…roject#18040) (opensearch-project#18042)

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

(cherry picked from commit 54e02a7)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…roject#18040)

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…roject#18040)

We've seen multiple failures where the 3 second timeout was breached.
This happens in the test setup of many different tests so multiple
individual test failures have been reported.

Also replace deprecated method in Kafka API and simplify a couple other
code paths.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 3.0 flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for IngestFromKafkaIT
2 participants