Skip to content

[Star tree] Remove star tree feature flag and add index setting to configure star tree search on index basis #18070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Apr 24, 2025

This change removes feature flag for star tree index and queries.

Description

  1. In both search (server/src/main/java/org/opensearch/search/DefaultSearchContext.java) and indexing validations (server/src/main/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeValidator.java) , we first check for explicit index setting and if present, we use the value otherwise we fallback to cluster setting.
  2. In search with the help of index setting, users will be able to turn off star tree search at index level if they want to test out / see issues etc.
  3. By default both the cluster setting "indices.composite_index.star_tree.enabled" and index setting "index.search.star_tree_index.enabled" are "true"

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 135be39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f7b7caf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a97f1eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 82001bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8bcc71f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5eb7ac3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5a90f9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5a90f9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5a90f9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f6c1cce: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 40d503d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rishabhmaurya rishabhmaurya merged commit bef982a into opensearch-project:main Jun 10, 2025
30 checks passed
q-andy pushed a commit to q-andy/OpenSearch that referenced this pull request Jun 11, 2025
…nfigure star tree search on index basis (opensearch-project#18070)

* Removing star tree indexing and queries added till 2.19 out of experimental

Signed-off-by: bharath-techie <[email protected]>

* Removing star tree feature flag

Signed-off-by: bharath-techie <[email protected]>

* Adding more tests for feature flag

Signed-off-by: bharath-techie <[email protected]>

* Adding Changelog

Signed-off-by: bharath-techie <[email protected]>

* addressing review comment

Signed-off-by: bharath-techie <[email protected]>

* resolving conflicts

Signed-off-by: bharath-techie <[email protected]>

---------

Signed-off-by: bharath-techie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants