-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add support for linux riscv64 platform #18156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for 46d7454: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
It appears that the Jenkins CI is successful but github workflow reports it as unsuccessful because jq failed to parse the response: https://github.com/opensearch-project/OpenSearch/actions/runs/14744106685/job/41388124137?pr=18156#step:7:635 I am not sure what's going on here. |
Re-triggered, force merge sometimes can mess up the gradle check logic. |
Seems like cross-compile from x86_64 is available then core is fine. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18156 +/- ##
============================================
- Coverage 72.53% 72.49% -0.04%
- Complexity 67207 67253 +46
============================================
Files 5476 5476
Lines 310436 310445 +9
Branches 45121 45121
============================================
- Hits 225179 225065 -114
- Misses 66894 67089 +195
+ Partials 18363 18291 -72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LGTM, thank you @kxxt , could you please resolve the conflicts? thank you |
Close opensearch-project#2341 Signed-off-by: Levi Zim <[email protected]>
Thanks! I have resolved the conflict. |
Looks like the CI is experiencing some network problem: https://github.com/opensearch-project/OpenSearch/actions/runs/14754049968/job/41419085283?pr=18156#step:3:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kxxt , @peterzhuamazon anything from your side?
- Add support for riscv64 linux, upstreamed: opensearch-project/OpenSearch#18156 - Backport patch to 2.19.1 - Vendor protoc becuase prebuilts are not available for riscv64 in maven repository - Tested basic functionalities.
Since this only exist in core not for bundle, I have no issues with the merge. |
And I would say remove the backport 3.0 label so that it will only affect starting 3.1.0. |
@andrross @peterzhuamazon seems like approval check is broken ... :( |
@peterzhuamazon Looks like the |
Checking. |
Hi @andrross @reta @peternied I have removed that check from every branch rule, then enable Thanks. |
- Add support for riscv64 linux, upstreamed: opensearch-project/OpenSearch#18156 - Backport patch to 2.19.1 - Vendor protoc becuase prebuilts are not available for riscv64 in maven repository - Tested basic functionalities.
Description
This PR adds support for linux riscv64 platform.
Cross building on x86_64 linux should be fine.
Building directly on riscv64 linux requires user to bring their own protoc executable because the maven repository does not ship prebuilt protoc executables for riscv64.
Related Issues
Resolves #2341
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.