-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update to crypto kms plugin for AWS SDK v2.x #18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gulshan <[email protected]>
@peterzhuamazon @cwperks how do i generate the new |
@kumargu Run |
❌ Gradle check result for 9f176ea: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gulshan <[email protected]>
❌ Gradle check result for 8c05300: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I will fix the failures and send our a new revision. |
❌ Gradle check result for a3e0d64: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gulshan Kumar <[email protected]>
ceb7f5e
to
d01ba50
Compare
❌ Gradle check result for d01ba50: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gulshan Kumar <[email protected]>
d01ba50
to
2523fee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18268 +/- ##
============================================
+ Coverage 72.50% 72.58% +0.08%
- Complexity 67379 67396 +17
============================================
Files 5488 5488
Lines 311062 311062
Branches 45217 45217
============================================
+ Hits 225520 225785 +265
+ Misses 67176 66846 -330
- Partials 18366 18431 +65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@cwperks this is ready for review. thanks. |
* Update to crypto kms plugin for AWS SDK v2.x Signed-off-by: Gulshan <[email protected]> * Remove duplicates and generate sha file Signed-off-by: Gulshan <[email protected]> * Include licenses and notices Signed-off-by: Gulshan Kumar <[email protected]> * Update change log Signed-off-by: Gulshan Kumar <[email protected]> --------- Signed-off-by: Gulshan <[email protected]> Signed-off-by: Gulshan Kumar <[email protected]>
* Update to crypto kms plugin for AWS SDK v2.x Signed-off-by: Gulshan <[email protected]> * Remove duplicates and generate sha file Signed-off-by: Gulshan <[email protected]> * Include licenses and notices Signed-off-by: Gulshan Kumar <[email protected]> * Update change log Signed-off-by: Gulshan Kumar <[email protected]> --------- Signed-off-by: Gulshan <[email protected]> Signed-off-by: Gulshan Kumar <[email protected]>
Description
Include the necessary dependencies for the crypto-kms plugin which were missed as part of #17396
This fixes broken local KMS integration
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.