Disabling _close API invocation during remote migration. #18327
Merged
+253
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Goyal <[email protected]>
rakshit98
force-pushed
the
validation/closeIndex
branch
from
7900ed3 to
7d5469b
Compare
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18327 +/- ##
============================================
+ Coverage 72.44% 72.55% +0.10%
- Complexity 67359 67376 +17
============================================
Files 5492 5492
Lines 311122 311129 +7
Branches 45220 45221 +1
============================================
+ Hits 225395 225727 +332
+ Misses 67372 66974 -398
- Partials 18355 18428 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gbbafna
reviewed
May 19, 2025
...src/internalClusterTest/java/org/opensearch/remotemigration/CloseIndexMigrationTestCase.java
Outdated
Show resolved
Hide resolved
shourya035
reviewed
May 19, 2025
server/src/main/java/org/opensearch/action/admin/indices/close/TransportCloseIndexAction.java
Outdated
Show resolved
Hide resolved
shourya035
reviewed
May 19, 2025
server/src/main/java/org/opensearch/action/admin/indices/close/TransportCloseIndexAction.java
Outdated
Show resolved
Hide resolved
shourya035
reviewed
May 19, 2025
...src/internalClusterTest/java/org/opensearch/remotemigration/CloseIndexMigrationTestCase.java
Outdated
Show resolved
Hide resolved
shourya035
reviewed
May 19, 2025
server/src/main/java/org/opensearch/action/admin/indices/close/TransportCloseIndexAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Goyal <[email protected]>
rakshit98
force-pushed
the
validation/closeIndex
branch
from
7d5469b to
484e545
Compare
Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna
approved these changes
May 20, 2025
|
❌ Gradle check result for da42ccb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
shourya035
approved these changes
May 20, 2025
|
❌ Gradle check result for da42ccb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Storage Project Board
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…project#18327) Signed-off-by: Rakshit Goyal <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…project#18327) Signed-off-by: Rakshit Goyal <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…project#18327) Signed-off-by: Rakshit Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to disallow API which are involved in closing index, when Document-Replication type to Segment-Replication type migration is happening.
Related Issues
Resolves #18328
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.