Replace the deprecated construction method of TopScoreDocCollectorManager with the new method in Lucene #18395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager with the new method Signed-off-by: Binlong Gao <[email protected]>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah and
a team
as code owners
Signed-off-by: Binlong Gao <[email protected]>
|
❌ Gradle check result for 2eab119: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18395 +/- ##
=========================================
Coverage 72.60% 72.61%
- Complexity 67682 67706 +24
=========================================
Files 5497 5497
Lines 311819 311817 -2
Branches 45265 45265
=========================================
+ Hits 226409 226417 +8
- Misses 66941 66954 +13
+ Partials 18469 18446 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
approved these changes
May 29, 2025
andrross
approved these changes
May 29, 2025
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…ager with the new method in Lucene (opensearch-project#18395) * Replace the deprecated construction method of TopScoreDocCollectorManager with the new method Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…ager with the new method in Lucene (opensearch-project#18395) * Replace the deprecated construction method of TopScoreDocCollectorManager with the new method Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 9, 2025
…ager with the new method in Lucene (opensearch-project#18395) * Replace the deprecated construction method of TopScoreDocCollectorManager with the new method Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the deprecated construction method of TopScoreDocCollectorManager with the new method in Lucene 10.1.0.
Related Issues
Resolves #18394.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.