Skip to content

Add node-left metric #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bhumikasharma29
Copy link
Contributor

Description

This PR will add a metric when there is a node drop. The tag will contain details about the node that as dropped and the reason for it.
Continues from #17949

Related Issues

None

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ Gradle check result for d8af721: SUCCESS

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (f048bb4) to head (a3638cd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/coordination/Coordinator.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18421   +/-   ##
=========================================
  Coverage     72.74%   72.74%           
- Complexity    68132    68167   +35     
=========================================
  Files          5537     5537           
  Lines        313312   313324   +12     
  Branches      45460    45461    +1     
=========================================
+ Hits         227921   227942   +21     
+ Misses        66873    66843   -30     
- Partials      18518    18539   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from d8af721 to 04fff47 Compare June 3, 2025 09:47
Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ Gradle check result for 04fff47: SUCCESS

@bhumikasharma29 bhumikasharma29 marked this pull request as ready for review June 4, 2025 04:54
@bhumikasharma29 bhumikasharma29 requested a review from a team as a code owner June 4, 2025 04:54
Copy link
Contributor

github-actions bot commented Jun 5, 2025

✅ Gradle check result for 04ddf96: SUCCESS

Copy link
Contributor

github-actions bot commented Jun 6, 2025

❌ Gradle check result for 8118c92: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Bhumika Sharma added 3 commits June 9, 2025 16:46
@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch 2 times, most recently from 539e252 to a94c5af Compare June 9, 2025 11:21
Copy link
Contributor

github-actions bot commented Jun 9, 2025

❌ Gradle check result for a94c5af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Gaganjuneja
Copy link
Contributor

Build is failing for spotless. Please fix.

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from a94c5af to 301b9c7 Compare June 9, 2025 11:44
Copy link
Contributor

github-actions bot commented Jun 9, 2025

❌ Gradle check result for 301b9c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from 301b9c7 to baaa386 Compare June 9, 2025 11:53
Copy link
Contributor

github-actions bot commented Jun 9, 2025

❌ Gradle check result for baaa386: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from baaa386 to 569888a Compare June 9, 2025 12:33
Copy link
Contributor

github-actions bot commented Jun 9, 2025

✅ Gradle check result for 569888a: SUCCESS

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from 4e617a2 to feca7b3 Compare June 10, 2025 15:07
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from feca7b3 to 91bea5d Compare June 10, 2025 15:55
Copy link
Contributor

✅ Gradle check result for 91bea5d: SUCCESS

Copy link
Contributor

✅ Gradle check result for ff8d798: SUCCESS

Copy link
Contributor

❌ Gradle check result for 00cab2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29
Copy link
Contributor Author

flaky test - #18476

Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/node-drop-metric branch from 00cab2a to f7c3205 Compare June 10, 2025 19:14
Signed-off-by: Bhumika Sharma <[email protected]>
Copy link
Contributor

❌ Gradle check result for f7c3205: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29
Copy link
Contributor Author

flaky test - #18485

Copy link
Contributor

❌ Gradle check result for 6f560bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for a3638cd: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bhumikasharma29
Copy link
Contributor Author

flaky test has failed - #14310

@Bukhtawar Bukhtawar merged commit b3ad02a into opensearch-project:main Jun 11, 2025
30 checks passed
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
* Add node-left metric

Signed-off-by: Bhumika Sharma <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
* Add node-left metric

Signed-off-by: Bhumika Sharma <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
* Add node-left metric

Signed-off-by: Bhumika Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants