-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update FipsMode check to catch NoSuchMethodError #18427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
❌ Gradle check result for 423fb1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18427 +/- ##
============================================
- Coverage 72.74% 72.64% -0.10%
Complexity 67767 67767
============================================
Files 5497 5504 +7
Lines 311815 311926 +111
Branches 45261 45286 +25
============================================
- Hits 226822 226591 -231
- Misses 66504 66848 +344
+ Partials 18489 18487 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…18427) Signed-off-by: TJ Neuenfeldt <[email protected]>
Description
This PR resolves an error seen in the security plugin here: https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370
The error is really a timing issue as the security plugin has not yet converted to BCFIPS jars because of incompatibility with OpenSAML which is a library used for SAML authentication.
The existing check has a catch block for NoSuchClassDef, but in the case of the security plugin the class exists, but the method does not.
Related Issues
Resolves https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.