Skip to content

Update FipsMode check to catch NoSuchMethodError #18427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jun 3, 2025

Description

This PR resolves an error seen in the security plugin here: https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370

The error is really a timing issue as the security plugin has not yet converted to BCFIPS jars because of incompatibility with OpenSAML which is a library used for SAML authentication.

The existing check has a catch block for NoSuchClassDef, but in the case of the security plugin the class exists, but the method does not.

Related Issues

Resolves https://github.com/opensearch-project/security/actions/runs/15408478290/job/43355642640?pr=5370

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner June 3, 2025 20:14
Signed-off-by: Craig Perkins <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 3, 2025

❌ Gradle check result for 423fb1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 3, 2025

✅ Gradle check result for 423fb1c: SUCCESS

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (d52cefa) to head (423fb1c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18427      +/-   ##
============================================
- Coverage     72.74%   72.64%   -0.10%     
  Complexity    67767    67767              
============================================
  Files          5497     5504       +7     
  Lines        311815   311926     +111     
  Branches      45261    45286      +25     
============================================
- Hits         226822   226591     -231     
- Misses        66504    66848     +344     
+ Partials      18489    18487       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit e21e7ec into opensearch-project:main Jun 4, 2025
32 of 34 checks passed
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Jun 9, 2025
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 9, 2025
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants