Ensure feature flags from opensearch.yml are set prior to plugin initialization #18432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing plugin initialization. Signed-off-by: Jing Zhang <[email protected]>
|
❌ Gradle check result for 65e7d42: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
finnegancarroll
approved these changes
Jun 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18432 +/- ##
============================================
- Coverage 72.74% 72.63% -0.11%
+ Complexity 67767 67699 -68
============================================
Files 5497 5499 +2
Lines 311815 311865 +50
Branches 45261 45271 +10
============================================
- Hits 226822 226518 -304
- Misses 66504 66827 +323
- Partials 18489 18520 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rishabhmaurya
changed the title
rishabhmaurya
approved these changes
Jun 5, 2025
andrross
reviewed
Jun 5, 2025
| @@ -525,6 +525,10 @@ protected Node(final Environment initialEnvironment, Collection<PluginInfo> clas | |||
| ); | |||
| } | |||
|
|
|||
| // Ensure feature flags from opensearch.yml are valid during plugin initialization. | |||
| // Bug fix: https://github.com/opensearch-project/OpenSearch/issues/18417 | |||
There was a problem hiding this comment.
Nitpick, but the commit message/PR description is the right place for this type of context. Unless it's a TODO or some other exception case we don't need to be adding issue links for code modifications.
1 task
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…ialization. (opensearch-project#18432) Signed-off-by: Jing Zhang <[email protected]>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…ialization. (opensearch-project#18432) Signed-off-by: Jing Zhang <[email protected]>
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 9, 2025
…ialization. (opensearch-project#18432) Signed-off-by: Jing Zhang <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ialization. (opensearch-project#18432) Signed-off-by: Jing Zhang <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…ialization. (opensearch-project#18432) Signed-off-by: Jing Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure feature flags from opensearch.yml are valid during plugin initialization.
Related Issues
#18417
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.